Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use nodes that are missing HelloResponse::NODE_HOST #52

Closed
wants to merge 1 commit into from

Conversation

dominics
Copy link
Contributor

@dominics dominics commented Jun 8, 2017

Fixes #46

@dominics
Copy link
Contributor Author

dominics commented Jun 8, 2017

Not really safe for merging because of e.g.

Notice: Undefined index: b27f65e00cb76bb4de71dab8148f3a09d93251cd in /vagrant/disque-php/src/Connection/Manager.php on line 199

Call Stack:
    0.0001     350824   1. {main}() /vagrant/disque-php/test.php:0
    0.0458     615432   2. Disque\Client->ping() /vagrant/disque-php/test.php:15
    0.0458     615488   3. Disque\Client->__call() /vagrant/disque-php/test.php:15
    0.0458     615488   4. Disque\Connection\Manager->execute() /vagrant/disque-php/src/Client.php:152
    0.0458     615488   5. Disque\Connection\Manager->shouldBeConnected() /vagrant/disque-php/src/Connection/Manager.php:185
    0.0458     615488   6. Disque\Connection\Manager->isConnected() /vagrant/disque-php/src/Connection/Manager.php:404
    0.0458     615488   7. Disque\Connection\Manager->getCurrentNode() /vagrant/disque-php/src/Connection/Manager.php:148

@dominics dominics closed this Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant