Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generateKeyPairSync for x25519 #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamuelScheit
Copy link

@SamuelScheit SamuelScheit commented May 5, 2023

  • Added support for generateKeyPairSync x25519
  • Added unit test
  • Works on iOS
  • Works on Android

Example code:

crypto.generateKeyPairSync('x25519', {
    publicKeyEncoding: { format: 'der', type: 'spki' },
    privateKeyEncoding: { format: 'der', type: 'pkcs8' }
});

@mrousavy
Copy link
Member

Hey! Thank you for your PR! ❤️

This looks amazing, let us test a bit and see if everything works as expected!

@EternalDeiwos
Copy link

Any chance this could also include ed25519?

@boorad
Copy link
Collaborator

boorad commented May 6, 2024

@SamuelScheit hiya, any chance you could rebase this onto main? I'm actively working issues/PRs now, so would love to get this in! 💪

FYI, I'm using some of your ideas in #304 (i.e. KeyVariant) so there may be conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants