Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableSmoothing prop #100

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chrispader
Copy link
Member

@chrispader chrispader commented Apr 15, 2024

Adds a enableSmoothing prop to <LineGraph /> and adds the necessary logic to create the Skia path (createGraphPath) and calculate the Y position for the gesture (getYForX)

@chrispader chrispader force-pushed the @chrispader/add-disable-smoothing-prop branch from 4654ae1 to d9461e5 Compare April 15, 2024 17:40
@chrispader chrispader marked this pull request as ready for review April 15, 2024 18:09
@chrispader chrispader force-pushed the @chrispader/add-disable-smoothing-prop branch from 7f968ba to 23e6e60 Compare April 15, 2024 18:11
Copy link
Member

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invert

@chrispader chrispader changed the title Add disableSmoothing prop Add enableSmoothing prop Apr 16, 2024
@techlabz
Copy link

I see an issue trying to use this branch, "synchronously call non-worklet function 'linearInterpolation' " have you guys gotten similar issues?

@techlabz
Copy link

Adding 'worklet' inside linearInterpolation solves this issue

@techlabz
Copy link

Unfortunately this still doesn't solve, the multiple data points on same day and also if there is a break with the dates on data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants