Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate <template> tag if it's not necessary #16

Open
marcoroth opened this issue Jan 4, 2023 · 0 comments · May be fixed by #18
Open

Don't generate <template> tag if it's not necessary #16

marcoroth opened this issue Jan 4, 2023 · 0 comments · May be fixed by #18
Labels
bug Something isn't working

Comments

@marcoroth
Copy link
Owner

Currently the helper generates <turbo-stream> elements always with the <template> tag, we should just generate it when it's actually needed.

For example, this call:

turbo_stream.reset_form("#form")

Currently generates:

<turbo-stream action="reset_form" targets="#form"><template></template></turbo-stream>
@marcoroth marcoroth added the bug Something isn't working label Jan 4, 2023
@marcoroth marcoroth linked a pull request Jan 8, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stream helpers powered by turbo-ruby marcoroth/turbo_power-rails
1 participant
@marcoroth