Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct types declarations align to source code #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JounQin
Copy link

@JounQin JounQin commented Jul 21, 2020

The following codes are actually incorrect but current types won't complain about it.

import { ElementQueries } from 'css-element-queries/src/ElementQueries'
import { ResizeSensor } from 'css-element-queries/src/ResizeSensor'

They should be like the following:

// by default
import * as ElementQueries from 'css-element-queries/src/ElementQueries'
import * as ResizeSensor from 'css-element-queries/src/ResizeSensor'

// or with `esModuleInterop: true` enabled
import ElementQueries from 'css-element-queries/src/ElementQueries'
import ResizeSensor from 'css-element-queries/src/ResizeSensor'

@ghost
Copy link

ghost commented Feb 6, 2022

a nice feature to be validated I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant