Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Groovy 4 to support Spring Boot 3 #33

Merged
merged 2 commits into from Aug 10, 2023
Merged

Updated to Groovy 4 to support Spring Boot 3 #33

merged 2 commits into from Aug 10, 2023

Conversation

wllianwd
Copy link
Contributor

Migrated to Groovy 4 so it can be used with Spring Boot 3:

  • Bump version to 3.0.0 as this is a major update
  • Updated to use the new org.apache.groovy
  • Updated Groovy to 4.0.11
  • Updated Spock to 2.3-groovy-4.0
  • Updated GMavenPlus to 2.1.0

@marcingrzejszczak
Copy link
Owner

@wllianwd can you rebase against main so that we see if a CI job hooks in this time?

@wllianwd
Copy link
Contributor Author

@wllianwd can you rebase against main so that we see if a CI job hooks in this time?

done

@michelzanini
Copy link

Any chance this can be merged? Thanks.

@marcingrzejszczak marcingrzejszczak added this to the 3.0.0 milestone Aug 10, 2023
@marcingrzejszczak marcingrzejszczak merged commit f76f621 into marcingrzejszczak:main Aug 10, 2023
1 check failed
@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

@marcingrzejszczak can you please release a version without this?
The whole point of #29 / #32 was to restore Groovy 2.5 compatibility by compiling with 2.5 again.
But this even increases the version to 4.0 so probably not only broke 2.5, but also 3.0 compatibility. 😭

@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

Yes, confirmed, Groovy 2.5 support is broken again while this release should fix it

@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

Just lowering the compile Groovy version to 2.5 again like in my PR, makes it again compatible with Groovy 2.5, 3.0, and 4.0.
Unfortunately, there is no MCVE available at all that shows why these changes here were necessary at all to maybe test with it and find an alternative.

@marcingrzejszczak
Copy link
Owner

Sorry for the mess. I've updated the project like this

4f1da9c - 2.0.1 will be Groovy 2.5.x compatible

b384e14 - 2.0.1-groovy-3.0 will be Groovy 3.0.x compatible

@marcingrzejszczak
Copy link
Owner

I have almost 0 time for this project so this is the fastest solution I came up with

@marcingrzejszczak
Copy link
Owner

BTW if you want to take it over @Vampire I don't mind ;)

@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

Thanks, but I already have more on my plate than I should eat. :-D

@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

Did you release those versions already and properly?
The Groovy 3 variant is listed already as version on central.sonatype.com, but both versions are not usable yet.

@marcingrzejszczak
Copy link
Owner

Thanks, but I already have more on my plate than I should eat. :-D

Don't we all? :D

Did you release those versions already and properly?

Yeah they are syncing to central, it might take a while

@marcingrzejszczak
Copy link
Owner

@Vampire
Copy link
Contributor

Vampire commented Aug 23, 2023

Yep, now it's there and works, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants