clean up auth and allow specifying request parameters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see http://docs.amazonwebservices.com/AmazonS3/latest/dev/index.html?RESTAuthentication.html#ConstructingTheCanonicalizedResourceElement the calculation of the canonicalized resource was not quite right. the problems were: * only one significant parameter (the first) was included * values of significant parameters were excluded * not all significant parameters were considered
see http://docs.amazonwebservices.com/AmazonS3/latest/API/index.html?RESTObjectGET.html the response-content-type, response-content-language, response-expires, response-cache-control, response-content-disposition, and response-content-encoding request parameters can be supplied to control the response headers of an S3 GET request. allow providing these to S3Object.url_for and have them included in the URL. bring along the other recognized parameters as well, while we're at it. also, make sure these parameters make it into the canonicalized request for authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details. Out immediate use case is being able to specify response-content-disposition when generating our S3 GET urls. I noticed the auth deficiencies while adding that.