This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Update terraform.py #1105
Merged
Update terraform.py #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that by v1.0, we should have terraform.py as a submodule, so upkeep is simpler. |
|
@sehqlr Agreed. |
|
This passed a basic install + healthy test. Are there any specific tests for this one? |
|
@sehqlr Nope! This should be ready to merge after we release 0.6. |
| attrs.update({ | ||
| 'consul_dc': _clean_dc(attrs['metadata'].get('dc', attrs['region'])), | ||
| 'role': attrs['metadata'].get('role', 'none') | ||
| 'role': attrs['metadata'].get('role', 'none'), | ||
| 'ansible_python_interpreter': attrs['metadata'].get('python_bin','python') |
There was a problem hiding this comment.
Why we need to touch stuff related to python_interpreter here?
There was a problem hiding this comment.
I'm not sure, maybe @BrianHicks would know.
|
When we move this to a submodule, where would the clone go? In the root directory? |
|
@sehqlr Let's make an issue for that and discuss there. |
|
I made an issue: #1120 |
Fixes #986
langston-barrett
force-pushed
the
feature/update-terraform.py
branch
from
cd5c908
to
b429ed0
Compare
|
Failure on AWS was quota-related. On GCE, Traefik health checks are failing, but that doesn't seem related. DO build passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986