Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox, per task #79 #85

Closed
wants to merge 61 commits into from
Closed

Lightbox, per task #79 #85

wants to merge 61 commits into from

Conversation

jesgs
Copy link
Member

@jesgs jesgs commented Aug 10, 2017

Pull-request type:

@jesgs

jesgs and others added 30 commits July 23, 2017 15:06
@jesgs @ardathksheyna
#27 Adding skeleton of comic bookmarking system
189663f
@jesgs @ardathksheyna
#27 Stub functionality for bookmarking system.
ec270a3
@jesgs @ardathksheyna
Task #27 Bookmarking system. Adding constants for key names.
c80fb4e
@jesgs @ardathksheyna
Task #27 Adding bookmark label state change.
2e4d3f6
@jesgs @ardathksheyna
Task #27 Comic bookmarking.
38b71aa
@jesgs @ardathksheyna
Task #27 Removing goto method. White-space adjustment in template-fun…
9ace02d 
…ctions.php
@jesgs @ardathksheyna
Task #27 Disabling bookmark links for browsers that don't support loc…
00e22b9 
…alStorage.
@jesgs @ardathksheyna
Task #27 Adding 'no bookmarks' message.
4c5d082
@jesgs @ardathksheyna
Task #27 Refactoring bookmarking to prevent duplication. Adding gette…
228a57e 
…rs and setters.
@jesgs @ardathksheyna
Task #27 A wild console.log has appeared! (and removed)
6ae66cd
@jesgs @ardathksheyna
Task #67 Adding i18n functionality to bookmarking
e229947
@ardathksheyna
Updating READMEs and version
16b6939
@ardathksheyna
Merge branch '4.0' into feature/bookmarking
29c1bfa
@ardathksheyna
Removing var_dump
b5d3288
@jesgs @ardathksheyna
Task #27 Extending markup for bookmark and bookmark history
470731d
@ardathksheyna
Correcting element ID name
720f648
@ardathksheyna
Correcting type-coersion
f897045
Merge branch 'master' into 4.0
7ccb5ba
Merge branch 'master' into 4.0
77d17dc
Readme updates
9549a9b
Merge branch '4.0' into feature/bookmarking
2f7363c
More readme updates
a944f8d
Merge branch '4.0' into feature/bookmarking
d842cd3
@jesgs
Adding 'remove' functionality
05d7c23
@jesgs
Removing TODO
8ad7ac3
@jesgs
Adding option for disabling styles. Adding CSS classes
612fe08
@jesgs
Merge pull request #82 from mangapress/feature/bookmarking
1b56ba3 
Feature/bookmarking
@jesgs
Update README.md
eb9bdf2
@jesgs
Adding options for lightbox
cbddf14
@jesgs
Refactoring sanitization for flexibility
511ed63
ardathksheyna and others added 25 commits August 4, 2017 21:05
@ardathksheyna
Converting properties to PSR-1 standards
820e82c
@ardathksheyna
Giving form elements their own namespace
8e7806f
@ardathksheyna
Updating README
b7d2306
@ardathksheyna
Further refactoring to bring closer to PSR standards
a587f14
@ardathksheyna
Updating docblocks
9c1ae16
@ardathksheyna
Additional namespace refactoring
d5d83b7
@ardathksheyna
Changing sanitization filter
1cc393f
@ardathksheyna
Removing unneeded method
bbb99d0
@ardathksheyna
Docblock addition
9437516
@ardathksheyna
Correcting semicolon to colon, removing var_dump/die statement
e599a23
@ardathksheyna
Additional plugin refactoring/restructuring
32ef17a
@ardathksheyna
Correcting asset path urls. Fixing default select value
bbd19c9
@ardathksheyna
DocBlock updates
b47e6b2
@ardathksheyna
Plugin header refactor. Adding dynamic version generation
70b7cfc
@ardathksheyna
Changing location of plugin function files
591b9bc
@ardathksheyna
Correcting Bootstrap/Posts references
796481e
@ardathksheyna
Changing upgrade routines.
1ebc969
@jesgs
Merge pull request #84 from mangapress/feature/option-refactor
ada7e3c 
Feature/option refactor
@ardathksheyna
#79 Adding file and enqueue process for lightbox.
5716bff
@ardathksheyna
Updating docblock
f5bdb41
@ardathksheyna
Docblock corrections, spacing, and typos
3aeed91
@ardathksheyna
Simple JS lightbox
dcce497
@ardathksheyna
Removing lightbox-specific code from latest comic template handlers. …
d245255 
…Creating filter
@ardathksheyna
Removing unneeded get_option line
1029845
@ardathksheyna
Adjusting behavior and removing unneeded classes
75706e8
@jesgs jesgs added this to the 4.0 milestone Aug 10, 2017
@jesgs jesgs closed this Aug 10, 2017
@jesgs jesgs removed the in progress label Aug 10, 2017
@jesgs jesgs deleted the feature/lightbox branch August 10, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Manga+Press 4.1
Awaiting triage
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesgs @ardathksheyna