Task #27 Adding 'no bookmarks' message.

mangapress · Sep 23, 2015 · 5211bba · 5211bba
1 parent 3590a2f
commit 5211bba
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/assets/js/bookmark.js b/assets/js/bookmark.js
@@ -1,5 +1,7 @@
 (function ($) {
-
+    /**
+     * @todo Add l10n/i18n support
+     */
     $(function() {
         var $bookmark = $('#bookmark-comic'),
             $bookmarkComicHistory = $('#bookmark-comic-history');
@@ -93,13 +95,7 @@
             var self = this,
                 revBookmarkHistory = JSON.parse(self.storage.getItem(self.BOOKMARK_HISTORY));
 
-            if (revBookmarkHistory.length == 0) {
-                // No bookmarks available
-                return;
-            }
-
-            var bookmarkHistory = revBookmarkHistory.reverse(),
-                $historyModal = $('<div id="bookmark-history-modal"><div id="bookmark-history-content"></div><p>[<a href="#" id="bookmark-history-close">close</a>]</p></div>')
+            var $historyModal = $('<div id="bookmark-history-modal"><div id="bookmark-history-content"></div><p>[<a href="#" id="bookmark-history-close">close</a>]</p></div>')
                     .css({
                         'width': '300px',
                         'z-index' : 9999,
@@ -112,7 +108,12 @@
                     });
 
                 $historyModal.find('#bookmark-history-content').html(function(){
-                    var htmlString = "<table>";
+                    if (revBookmarkHistory.length == 0) {
+                        return '<p>No bookmark history available.</p>';
+                    }
+
+                    var htmlString = "<table>",
+                        bookmarkHistory = revBookmarkHistory.reverse();
 
                     htmlString = "<thead><tr><td>Title</td><td>Date</td></tr></thead>";