Revert to C++17 build #1542
Merged
Revert to C++17 build #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
force-pushed
the
revert_to_cxx17
branch
from
ce70431
to
a2769af
Compare
alexowens90
requested changes
May 2, 2024
cpp/arcticdb/log/log.cpp
Outdated
| @@ -72,7 +72,7 @@ struct Loggers::Impl | |||
|
|
|||
|
|
|||
| constexpr auto get_default_log_level() { | |||
| return spdlog::level::info; | |||
| return spdlog::level::trace; | |||
There was a problem hiding this comment.
This needs backing out
There was a problem hiding this comment.
Oops, good spot
There was a problem hiding this comment.
Keep meaning to write a test for this 'cos I do it all the time
willdealtry
force-pushed
the
revert_to_cxx17
branch
from
d2c6d54
to
9362492
Compare
alexowens90
approved these changes
May 3, 2024
willdealtry
force-pushed
the
revert_to_cxx17
branch
from
7e81c77
to
8365209
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with C++20 causes sigabrt when ray is imported first. Temporarily revert to C++17