-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow (UI) configuration option #2068
base: master
Are you sure you want to change the base?
Conversation
General stuff I noticed while looking at the code:
one time error log:
|
Thanks for your feedback on these changes!
Interesting - I hadn't spotted the sources with wizards. I'll take a look into that.
Agreed, I'll look into that.
Agreed. I couldn't see a good way to intepret this type of input requirement. It would be a fair bit of initial work but maybe its worth introducing a JSON (or other machine readable) 'definition' of each source?
Seems reasonable - I didn't go any further with ICS because I wanted to keep it as 'generic' as possible. There were a couple of things like request headers that I'd like to add support for in the UI.
'user' is the first step the UI setup wizard calls. See this table. You could have a step called country thats called straight away from the user step though...
Fixed :)
That looks to be caused by my type 'guessing' logic. I'll see if I can reproduce that. |
I made some updates dan-r#1 @dan-r what do you think? (fixes @muchcodesuchwow issue as well) |
Implements config flow configuration whilst retaining support for YAML configuration. Resolves #2016.
There's some automated testing needed, but I'd appreciate some community testing with this fork as so far I've only tested with a few areas local to me.
Customise functionality is not supported as this time, but the basic functionality (incl. ICS) is there.
This feature borrows very heavily from the config_flow branch, but takes a different approach with how sources are handled. Instead of templating the language and constants files, a JSON list of sources is written by update_docu_links.py and read during the config flow.
Config.flow.setup.mov