Add a skeleton for a new Recreativos Franco slot game and move all RF drivers to their own folder #12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… drivers to their own folder New not working machine ----------------------------- Jail Break (Recreativos Franco slot machine) [Hammy, ClawGrip]
angelosa
reviewed
May 1, 2024
src/mame/recfranco/rfjailbrk.cpp
Outdated
| rfjailbrk_state(const machine_config &mconfig, device_type type, const char *tag) | ||
| : driver_device(mconfig, type, tag) | ||
| , m_maincpu(*this, "maincpu") | ||
| , m_okim6376(*this, "oki") |
There was a problem hiding this comment.
I dislike this naming. I don't need to remember this being 6376 in code, can as well be short-handed to m_oki as also the device tag hints.
There was a problem hiding this comment.
You mean changing m_okim6376(*this, "oki") to m_oki(*this, "okim6376") ??
Thanks!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New not working machine
Jail Break (Recreativos Franco slot machine) [Hammy, ClawGrip]