First Commit #258

RonanHughes1 · 2022-07-11T09:19:43Z

Ronan Hughes Code Review

erb16 · 2022-07-11T09:38:10Z

views.rb/index.erb

+        <input type="submit" value="Submit">
+    </li>
+ </ul>
+</form>


nicely formatted html (with the indentations and stuff)

erb16 · 2022-07-11T09:41:08Z

lib/player.rb

+    def name 
+        return name 
+    end
+end


single responsibility principle seems good here

erb16 · 2022-07-11T09:43:59Z

spec/features/player_spec.rb

+            expect( player.name ).to eq "Ronan"
+        end
+    end
+end


test is easy to understand

erb16 · 2022-07-11T09:50:10Z

app.rb

+  get '/play' do
+    @player1 = $player1.name
+    @player2 = $player1.name
+    erb :play


does :play need to be in brackets?

erb16 · 2022-07-11T09:51:58Z

app.rb

@@ -1,8 +1,28 @@
 require 'sinatra/base'
+require 'sinatra/reloader'
+


need a require './lib/player'

erb16 · 2022-07-11T09:55:51Z

app.rb

+  end
+  get '/' do
+   "hey"
+  end


may need to introduce erb (:index) here so that the user can move forward onto next page

First Commit

e18f1e0

erb16 reviewed Jul 11, 2022

View reviewed changes

Provide feedback