Laila #221
Open
Laila #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| get '/peeps/new' do | ||
| erb :"new" |
tomfuller
reviewed
Apr 20, 2022
| erb :"new" | ||
| end | ||
|
|
||
| post '/peeps' do |
There was a problem hiding this comment.
I would try and keep your route naming consistent, as above you are getting '/peeps/new/' I would also post 'peeps/new' here as this post is creating a new peep.
tomfuller
reviewed
Apr 20, 2022
| end | ||
|
|
||
| def self.all | ||
| if ENV['ENVIRONMENT'] == 'test' |
There was a problem hiding this comment.
This if else statement is going to be required in any function in this class and its already adding a lot of bloat just being used twice, could this be extracted into its own function?
|
This a nice solution, well done! You have great test coverage and your routes are mostly tidy. I have left a couple of comments where there are some small things that could be improved. Please let me know if you have any questions about any of it and we can chat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Please write your full name here to make it easier to find your pull request.
LAILA GHARZAI
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!