Update QueueModerator.java #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get ```IndexOutOfBoundsException``` error
Add some code to help user to how can we use download multiple task
| @@ -37,36 +37,43 @@ public QueueModerator(TasksDataSource tasksDataSource, ChunksDataSource chunksDa | |||
| this.moderator = localModerator; | |||
| this.moderator.setQueueObserver(this); | |||
| this.listener = downloadManagerListener; | |||
| this.downloadTaskPerTime = downloadPerTime; | |||
|
|
|||
| if (tasks.size() < downloadPerTime) { | |||
There was a problem hiding this comment.
Maybe It's better to write something like this
this.downloadTaskPerTime = downloadPerTime;
if (tasks.size() < downloadPerTime) {
this.downloadTaskPerTime = tasks.size();
}But why?
There was a problem hiding this comment.
yes you have right, its better than my code
| this.uncompletedTasks = tasks; | ||
|
|
||
| downloaderList = | ||
| new HashMap<Integer, Thread>(downloadTaskPerTime); | ||
| downloaderList =new HashMap<>(downloadTaskPerTime); |
There was a problem hiding this comment.
downloadTaskPerTime variable still final ?
There was a problem hiding this comment.
@Alamusitl are you familiar with this library?
Add DeleteAllUncompletedsDownloads from database and files
add allUnCompleteds function
Fix latest commit for downloadTaskPerTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX BUG: get exception when task size is less than downloadPerTime