Improve HTTP error handling #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jun 9, 2023
|
Probably want to add an entry to the CHANGELOG for this as well? |
thrawn01
force-pushed
the
thrawn/http-errors
branch
from
41b3bf6
to
e497832
Compare
thrawn01
force-pushed
the
thrawn/http-errors
branch
from
e497832
to
f647580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To improve how we report errors when making HTTP calls to other
groupcacheinstances. See #59 for details on the proposal.Implementation
groupcache.ErrNotFoundwhich should be returned from an implementation ofGetterFuncto indicate the requested value is not availablegroupcache.ErrRemoteCallwhich is returned fromgroup.Get()when an error that is not aErrNotFoundis returned during a remote HTTP instance call