Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version from docker-compose.yml #5845

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

iamspido
Copy link

With docker version 25.05 the version 2.1 in docker-compose.yml will be obsolete.
docker-compose.yml: version is obsolete

Fix for #5797

FreddleSpl0it and others added 2 commits April 4, 2024 08:50
With docker version 25.05 the version 2.1 in docker-compose.yml will be obsolete.
docker-compose.yml: `version` is obsolete
@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@iamspido iamspido changed the base branch from master to staging April 16, 2024 12:14
@JiiPee74
Copy link

JiiPee74 commented May 3, 2024

This is only warning and removing it from config file may break older docker installations, so I would leave it for now.

@tomudding
Copy link
Contributor

This is only warning and removing it from config file may break older docker installations, so I would leave it for now.

The version attribute has been optional since the new Compose specs released at the end of 2020, see https://github.com/docker/compose/releases/tag/1.27.0-rc1 and compose-spec/compose-spec@649d3b0.

Any recent version of Mailcow requires Compose v2 to be able to work, which has the above change since its inception. So if someone is still using a version of Compose that uses/only supports the v1 spec there are likely more serious issues with that system that require attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants