New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): pin snowflake to v0.0.3 (#15352) #15356
base: v1.8
Are you sure you want to change the base?
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
4eb801a
to
cb20455
Compare
cb20455
to
a9a57d4
Compare
Hi, @ardzoht , Sorry for bothering you. I wonder if you could have a look at this PR. The Some CI test failed, but I believe they are unrelated to the PR. Thanks! |
a9a57d4
to
2fbbd0e
Compare
For the reviewer: For backporting we have https://github.com/magma/magma/blob/master/.github/workflows/backport-pull-request.yml, that works based on labels. Not sure if that is still functional. |
Thanks, @maxhbr . Indeed, this commit is not a backport, just a quick fix for v1.8. When I have some time, I plan to send a PR with the proper fix to |
@rogerpueyo Thanks for this. I will review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Researched the odd history of the package. Verified that 0.0.3 is a reasonable stopping point.
Two problems remaining:
|
https://magmacore.slack.com/archives/C0191LLL03S/p1707864815948919
|
The snowflake package used to create a UUID, e.g., for an AGW's /etc/snowflake file has been renamed to snowflake-uuid, and the former snowflake package has been taken over by a completely different piece of software. Pinning the package version to v0.0.3 ensures that we fetch the latest available release of the former snowflake package, before the name change. Fixes magma#15352 for v1.8. Signed-off-by: Roger Pueyo Centelles <roger.pueyo@i2cat.net>
2fbbd0e
to
36b99aa
Compare
@panyogesh Is it possible to include this in the current round of merges? |
The
snowflake
package used to create a UUID, e.g., for an AGW's/etc/snowflake
file has been renamed tosnowflake-uuid
, and the formersnowflake
package has been taken over by a completely different piece of software. Pinning the package version tov0.0.3
ensures that we fetch the latest available release of the formersnowflake
package, before the name change.Fixes #15352 for Magma
v1.8
.Summary
The snowflake package dependency was pinned to v0.0.3 in both
bazel/external/requirements.in
andorc8r/gateway/python/setup.py
. This ensures that the latest release of the formersnowflake
package is fetched and the/etc/snowflake
file is generated correctly.Test Plan
Tested on a
v1.8
AGW in a Vagrant VM. Themagmad
service no longer complains about the snowflake package as detailed in #15352, and it correctly starts the rest of services. Also, theshow_gateway_info.py
reports a valid hardware ID (instead of miserably failing).Additional Information
Security Considerations
For
master
and upcoming≥v1.9
Magma releases, the new package namesnowflake-uuid
shall be used.