-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageSpeed Insights - Ensure text remains visible during webfont load #834
Conversation
Fixed and result changes - All text remains visible during Webfont loads
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Static Tests failed in a different place in the code - anyone can help on this as changes have not impacted that. |
HI @kanhaiya5590, as part of the process, need to fix the static test failures in the file that was edited. |
app/code/Magento/PageBuilder/view/frontend/web/css/source/_icons.less
Outdated
Show resolved
Hide resolved
@magento run all tests |
We are picking this PR for further development |
@magento run Static Tests |
@magento run Static Tests |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
@magento run Functional Tests EE |
@magento run Functional Tests EE, Functional Tests B2B |
The Failed tests seem flaky to me. Hence moving this PR in testing |
@magento run Functional Tests EE, Functional Tests B2B |
Hi @kanhaiya5590, Thanks for the collaboration & contribution!. We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshot. Could you please try to reproduce the issue in Latest 2.4-develop instance and could you please let us know if we are still missing anything. Thanks. |
Hi @kanhaiya5590, We are not able to reproduce the issue. Can you please confirm the issue still exist on 2.4-develop? please refer to this #834 (comment) Lets us know if you are still facing the issue on 2.4-develop with detailed steps. Moving it to Thanks. |
HI @kanhaiya5590, Thank you for your contribution! As mentioned #834 (comment), please have a look and let us know if we are missing anything. Till then closing this PR. Please feel free to reopen it as you want to update further. Thank you! |
Description (*)
Task
https://pagespeed.web.dev/ - PageSpeed Insights
Performance improvement - after changes result => All text remains visible during Webfont loads
Before changes - Ensure text remains visible during Webfont load
After changes - All text remains visible during Webfont loads