New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC_ROLES_MAPPING support #5053
Merged
wangxiaoyou1993
merged 11 commits into
mage-ai:master
from
mihaivint:OIDC_USER_ROLES_MAPPING
May 14, 2024
Merged
Add OIDC_ROLES_MAPPING support #5053
wangxiaoyou1993
merged 11 commits into
mage-ai:master
from
mihaivint:OIDC_USER_ROLES_MAPPING
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that if mapping variable is not defined it maintains the user_roles behaviour |
can you add unit tests for this? the code looks good otherwise |
Added, but that section is pain to test without rest of the code. |
wangxiaoyou1993
approved these changes
May 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add support for OIDC_ROLES_MAPPING environment variable:
#5052
How Has This Been Tested?
Using Vault OIDC provider using the following scope template for OIDC provider:
In case OIDC_ROLES_MAPPING is not defined user_roles remains with normal behaviour and should look like this:
Checklist