Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jk] Update Trigger SLA start condition #4705

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnson-mage
Copy link
Member

@johnson-mage johnson-mage commented Mar 5, 2024

Description

  • Use a trigger's started_at time (instead of execution_date) for calculating when its SLA time limit has been exceeded (and trigger's passed_sla property is updated to true). Also check trigger's pipeline runs with running status, excluding runs with initial status, when calculating SLA time limit.
  • Update pipeline runs table to visually indicate runs that have exceeded SLA time limit (passed_sla is true).

How Has This Been Tested?

  • Updated unit tests
  • Tested in both single-project and multi-project setups

Pipeline runs table with run that has exceeded SLA of 1 minute ("Execution time" has yellow font color):
image

These 5 pipeline runs in the screenshot below were executed at the same time for a pipeline with a pipeline_run_limit of 1 for its concurrency config (meaning only 1 pipeline run can run at a time). None of the pipeline runs exceeded the SLA time limit (previously, the pipeline runs besides the initial run were being flagged as exceeding the SLA limit even though their execution times were below it).
image

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

@johnson-mage johnson-mage added the bug Something isn't working label Mar 5, 2024
@johnson-mage johnson-mage self-assigned this Mar 5, 2024
@johnson-mage johnson-mage requested review from dy46 and wangxiaoyou1993 and removed request for dy46 March 5, 2024 02:11
@johnson-mage johnson-mage force-pushed the jk--update_sla_start_condition branch from 571b679 to 7626e90 Compare March 5, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant