[jk] Update Trigger SLA start condition #4705
Open
+50
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
started_at
time (instead ofexecution_date
) for calculating when its SLA time limit has been exceeded (and trigger'spassed_sla
property is updated totrue
). Also check trigger's pipeline runs withrunning
status, excluding runs withinitial
status, when calculating SLA time limit.passed_sla
istrue
).How Has This Been Tested?
Pipeline runs table with run that has exceeded SLA of 1 minute ("Execution time" has yellow font color):
These 5 pipeline runs in the screenshot below were executed at the same time for a pipeline with a
pipeline_run_limit
of1
for its concurrency config (meaning only 1 pipeline run can run at a time). None of the pipeline runs exceeded the SLA time limit (previously, the pipeline runs besides the initial run were being flagged as exceeding the SLA limit even though their execution times were below it).Checklist
docs/mint.json