Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xh]Add date support for oracle destination #4646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matrixstone
Copy link
Collaborator

Description

To fix: #4587, this PR add date support for destination oracle.
So it can create table with Date column and convert source datetime data into oracle.

How Has This Been Tested?

Tested with Mage UI:
Required catalog config: catalog_setting

Written table and data:
data written

Job sucess written:
job success

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:
@wangxiaoyou1993

@matrixstone matrixstone added the feature New feature or request label Feb 25, 2024
@wangxiaoyou1993
Copy link
Member

can you fix the unit tests?

@matrixstone
Copy link
Collaborator Author

Fixed unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IndexError on OracleDB yaml data exporter when key column or only datetime as column type is assigned
2 participants