Enhanced Mongodb integration source client update #4261
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added serverSelectionTimeout to enhance connection speed - Implemented fallback connection method in case of ServerSelectionTimeoutError - Adjusted logging for clearer error and status messages
paul-data-ai
changed the title
|
Hi @paul-data-ai , could you resolve the code quality check errors? You can set up pre-commit hook locally: https://github.com/mage-ai/mage-ai/blob/master/README_dev.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerSelectionTimeoutErrorwhen using MongoDB as source for data integration.Description
This pull request introduced mainly a fallback method to the original method of connecting to MongoDB client when used as source for data integration. The main method often results in
serverselectiontimeout, which doesn't occur with the fallback method.How Has This Been Tested?
serverSelectionTimeoutworks as expected.ServerSelectionTimeoutErrorand the alternative format for passing credentials to the client builder to validate the effectiveness and reliability of the fallback connection method.Checklist
cc: @tommydangerous