New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New parser #3
New parser #3
Conversation
Small nitpick: could we use camelCase instead of snake_case? :) |
oops, I've been writing in a lot of python recently >.> |
if (indented) return result[latest].push(line.trim().split(/\s+/)) | ||
if (indented) return result[latest].push(line.trim()) | ||
|
||
latest_line = line.trim().split(/\s+/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably mean var latest_line
since otherwise this is a global variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, thanks!
Great work! Released as 2.0.0 |
Make changes to hackfile parser for new format.
Context:
#2
dat-ecosystem-archive/gasket#17