Add "cli callback" for streaming output #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Program specified by user (currently hardcoded) will be invoked, the contents of the file being extracted supplied to its stdin, and its stdout saved instead of original file. It is something like `--to-command` from GNU tar I think it is way more universal than madler#4 which is kind of useless when you have more than one file in archive (and care about outputed filenames) Unfortunately prog's exit code is curently ignored - sunzip will keep running even if prog fail. This kinda suck, but it hugely simplifies integration with programs that panic on unrecognized input. TODO: - Add CLI (prog is curently hard-set to `tac` for testing purposes) - Improve child cleanup - Add option to enable exit code checking or at least inform on which files error occured - Add support for non-posix systems or at least make it optional feature (currently build on non-posix will probably fail)
Add folowing flags, and docs about them -c cmd [cmd_arg ...] ; Pipe each extracted file to specified program and save its stdout on disk. All arguments beetween prog_name and semicolon are used as its args. Unfortunately prog's exit status is ignored - sunzip will keep running even if prog fail (Yeah, that sucks) Note: semicolon might need to be escaped with '\' to protect it from being intercepted by shell -j n: limit concurent jobs spawned by -c. Default: 1 Sorry for quite big diff: - I rewrote arg parsing logic, because it was easier to do that than to integrate `-c` flag into old one. I hope that I didn't break compat doing that - I changed help text format a bit TODO (maybe): handle -j without spaces like -j5
Bug was caused by waiting for termination of child that wasn't suplied any data yet
I simply forgot about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-c cmd [cmd_arg ...] ;option which, for each extracted file will spawn supplied program, supply decompressed file to its stdin and save its stdout instead of original file.Add
-j noption, for specifing count of concurent instances of spawned callbacksIt allows for downloading, unziping and processing files without storing originals on disk
For example:
curl "https://dd.b.pvp.net/latest/set1-lite-en_us.zip" | sunzip -j 4 -c cwebp -quiet -m 5 -o - -- - \;sunzip -c md5sum - \; -j 2 < archive.zip(very likely useless, but nice for testing)Problems with this patch:
bye()implementationI done this for fun and don't have any particular use case for this (actually, I had, but this was another useless project done for fun), thus i don't have much motivation for polishing this, but I can try if you would be willing to merge this