Add #defines for zip constants. Fix bug in GOOD macro, and missing check for stored method #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#defines are introduced for zip constants to improve readability.
bugfix1: In the course of unzipping a record with a data descriptor and trying the various possibilities, additional bytes can be read into the input buffer by the load() macro causing in->count to jump by CHUNK bytes. To avoid this, the value of in->count is stored in a separate local variable for checking in the revised GOOD() macro.
bugfix2: Deferred lengths (data descriptors) are also seen for "stored" method with no compression, so ensure that is supported too by correcting a missing if check.