Suggested build instructions #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to address issue #1
See Markdown rendering on https://github.com/stain/sunzip/blob/build-instructions/README.md
Obviously build instructions will vary alot by OS, but I thought an example for Debian/Ubuntu might be helpful, in particular as
contrib/blastandcontrib/infback9are not compiled (or even included) in their outdated zlib.I probably got half the
gccoptions wrong.. please help! :) Perhaps it should compilelibzas a static library to avoid the-rpathtrick? Or should one simply compile the contribs against the older systemzlib1g-dev(1.2.11 in Ubuntu 18:04, 1.2.8 in Debian 9)?I also added a
Dockerfileto create a Docker image (to test my instructions). The instructions to build that suggestmadler/sunzipas Docker image name. You could add an automated build on https://cloud.docker.com/ which would pick up thisDockerfileand re-build on any changes here. To test it today try my test-buildstain/sunzip.