Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump actions/cache from 3 to 4 #1487

Merged
merged 1 commit into from Apr 22, 2024
Merged

Conversation

ichizok
Copy link
Member

@ichizok ichizok commented Apr 20, 2024

No description provided.

@ychin
Copy link
Member

ychin commented Apr 21, 2024

For some reason this is failing the macos-12 runner tests in test_playsound. There was a fix in CI to enable sound permissions but it's supposed to only be needed for macos-14. I wonder if the "Grant microphone access for macos-14" step in ci-macvim.yaml needs to just include every version of macOS, somehow.

@ychin ychin merged commit e10ad1f into macvim-dev:master Apr 22, 2024
4 of 5 checks passed
@ychin ychin added Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes. labels Apr 22, 2024
@ichizok ichizok deleted the actions/cache-4 branch April 22, 2024 05:47
@ichizok
Copy link
Member Author

ichizok commented May 2, 2024

Based on my investigation; macos-12 runner runs on any one of (at least) 3 machines:

$ log show --no-pager | head -n2

1

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-03-29 02:09:32.000000-0700 0x0        Timesync    0x0                  0      0    === system boot: 8F30006D-B8A0-48E7-8749-DF48371DD59C

2

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-04-04 13:48:52.000000-0700 0x0        Timesync    0x0                  0      0    === system boot: F1D48C73-D273-4888-98C5-AAE42396C09D

3

Timestamp                       Thread     Type        Activity             PID    TTL  
2024-04-18 12:43:46.000000+0000 0x0        Timesync    0x0                  0      0    === system boot: 3B270419-7E13-4B6D-B7DE-4AD0B8459F3F

1 and 2 have no audio device, and 3 has NullAudio device.

$ system_profiler SPAudioDataType

1,2

Audio:

    Devices:

3

Audio:

    Devices:

        Null Audio Device:

          Default Input Device: Yes
          Default Output Device: Yes
          Default System Output Device: Yes
          Input Channels: 2
          Manufacturer: Apple Inc.
          Output Channels: 2
          Current SampleRate: 44100
          Transport: Virtual
          Input Source: Data Source Item 0
          Output Source: Data Source Item 0

$ ls -l /Library/Audio/Plug-Ins/HAL

1,2

ls: /Library/Audio/Plug-Ins/HAL: No such file or directory

3

total 0
drwxr-xr-x  3 root  wheel  96 Jun 13  2023 NullAudio.driver

Therefore test_sound fails when it runs on 1 or 2 since no audio device.

Ref:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants