Fix misc MacVim project warnings in Xcode #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
force-pushed
the
fix-xcode-project-warnings-parallel-deployment-target
branch
from
3146b61
to
b91d231
Compare
Turn on parallel building, to remove the "Building targets in manual order is deprecated" project warning. Also, fix configure to only set macOS deployment target to the major version of macOS when automatically setting it from the client OS version. E.g. On macOS 13.2 it will set deployment to 13.0. This is useful because usually we don't want it to be as granular as the minor version which had caused issues in Homebrew before (Homebrew/homebrew-core#111693) where they had to fix on their end, and also 13.2 ends up being too new for Xcode which only expects to see up to 13.1 as deployment target. - Note that the logic used to work in OSX 10.X days because the "minor" version of X is actually the OS version, whereas in macOS 11/12/13 we now have versions like 13.2 where the first number is now the OS version. The configure script will now detect whether it's 10.X.Y or X.Y (X != 10) and set the correct target correspondingly.
ychin
force-pushed
the
fix-xcode-project-warnings-parallel-deployment-target
branch
from
b91d231
to
e443fb4
Compare
ychin
added
the
Non User Facing
tono
pushed a commit
to tono/macvim
that referenced
this pull request
Mar 21, 2023
…ngs-parallel-deployment-target Fix misc MacVim project warnings in Xcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on parallel building, to remove the "Building targets in manual order is deprecated" project warning.
Also, fix configure to only set macOS deployment target to the major version of macOS when automatically setting it from the client OS version. E.g. On macOS 13.2 it will set deployment to 13.0. This is useful because usually we don't want it to be as granular as the minor version which had caused issues in Homebrew before (Homebrew/homebrew-core#111693) where they had to fix on their end, and also 13.2 ends up being too new for Xcode which only expects to see up to 13.1 as deployment target.