Skip to content

Commit

Permalink
Allow Sparkle release notes to use JavaScript so videos work
Browse files Browse the repository at this point in the history
Currently, it's hard to embed video in the release notes shown to
Sparkle, because by default it disables JavaScript, which video tags
need in order to work properly for the WebKit embedded browser. Turn it
on, so that we can show video instead of animated GIF's in the future
for release notes.

I don't think there should be any serious security issues after thinking
about it. The browser is sandboxed and we are serving this through https
anyway.
  • Loading branch information
ychin committed Feb 7, 2023
1 parent 2e74830 commit 905db20
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/MacVim/Info.plist
Expand Up @@ -1309,6 +1309,8 @@
</dict>
</dict>
</array>
<key>SUEnableJavaScript</key>
<string>YES</string>
<key>SUFeedURL</key>
<string>https://macvim.org/appcast/latest.xml</string>
<key>SUPublicEDKey</key>
Expand Down

0 comments on commit 905db20

Please sign in to comment.