Merge pull request #1361 from ychin/fix-tab-remaining-tracking-tag-crash

Fix remaining tab crash from not clearing tracking tags correctly
macvim-dev · Feb 7, 2023 · 76b9df2 · 76b9df2
2 parents b2dacc5 + 3906462
commit 76b9df2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/MacVim/PSMTabBarControl/source/PSMTabBarControl.m b/src/MacVim/PSMTabBarControl/source/PSMTabBarControl.m
@@ -476,9 +476,11 @@ - (void)removeTabForCell:(PSMTabBarCell *)cell
     [[NSNotificationCenter defaultCenter] removeObserver:cell];
     if([cell closeButtonTrackingTag] != 0){
         [self removeTrackingRect:[cell closeButtonTrackingTag]];
+        [cell setCloseButtonTrackingTag:0];
     }
     if([cell cellTrackingTag] != 0){
         [self removeTrackingRect:[cell cellTrackingTag]];
+        [cell setCellTrackingTag:0];
     }
 
     // pull from collection
@@ -665,9 +667,11 @@ - (void)update
         [[NSNotificationCenter defaultCenter] removeObserver:cell];
         if([cell closeButtonTrackingTag] != 0){
             [self removeTrackingRect:[cell closeButtonTrackingTag]];
+            [cell setCloseButtonTrackingTag:0];
         }
         if([cell cellTrackingTag] != 0){
             [self removeTrackingRect:[cell cellTrackingTag]];
+            [cell setCellTrackingTag:0];
         }
     }