Conflict with SwiftUI: Renaming Classes to RImageRessource and RColorRessource #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SwiftUI.ColorRessource (iOS 17.0+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Apple has introduced two new classes, ImageResource and ColorResource, in SwiftUI. These classes have the same names as our existing classes, ImageRessource and ColorRessource, which has led to a naming conflict.
Solution:
To avoid this conflict and ensure the smooth functioning of our package, I have renamed our classes as follows:
Why This Change is Necessary:
By renaming our classes, we prevent any ambiguity when developers use our package alongside SwiftUI. This change aligns with best practices to avoid naming conflicts and ensures that our package remains compatible with the latest iOS SDK.
Links to Apple Documentation:
Apple's ImageResource Documentation
Apple's ColorResource Documentation
Impact:
This change may require updates in the codebase where our package is used. Developers will need to update references to the old class names (ImageRessource and ColorRessource) to the new names (RImageRessource and RColorRessource) to ensure compatibility.