Small optimisations to PYON encoding #38
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing a couple of performance issues when serialising large PYON files1. This PR makes a couple of changes to the PYON encoder to improve performance without changing behaviour:
json.dumps
to quote strings, rather thanstr.translate
, which is significantly faster. This does mean that unicode characters are encoded as escape sequences instead, but they should serialise the same.Here is a quick summary of the time taken to serialise a 1.7GiB PYON object across the commits in this PR:
Footnotes
Most notably within the ARTIQ dashboard's
StateManager
, where serialising the dashboard state can cause the UI to hang for several seconds. ↩