User#send_reset_password_instructions redirect_url not set as default if blank #1253
Conversation
| @@ -330,8 +330,7 @@ class DeviseTokenAuth::PasswordsControllerTest < ActionController::TestCase | |||
| DeviseTokenAuth.default_password_reset_url = @redirect_url | |||
There was a problem hiding this comment.
@redirect_url isn't null, why this change in the spec ?
There was a problem hiding this comment.
The test was to test "Using default_password_reset_url", however previously the redirect url was passed as a param, and that's why the spec passed, and thus the change in the spec to show that the test is still valid without the url being passed to the controller
There was a problem hiding this comment.
and how the spec in line 61 passes? we have a validation for the missing redirect url in the controller
There was a problem hiding this comment.
@MaicolBen My bad, it looks like on
,DeviseTokenAuth.default_password_reset_url is already used as a backup for @redirect_url, hence the spec in line 61 passes.
The issue I wanted to fix in this PR is really for resource.send_reset_password_instructions where the method would still work if no redirect_url is passed as an option, eg: calling it directly. Since there isn't a test to cover send_reset_password_instructions, do I need to create a new test for this?
There was a problem hiding this comment.
If you can, add a spec for this case in the model
… be set to default url if not present in opts
mengqing
force-pushed
the
fix-send-reset-password-instructions-redirect-url
branch
from
552a753
to
2ada9f3
Compare
redirect_urlshould be set toDeviseTokenAuth.default_password_reset_urlif not present in the options