Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logview.go #657

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update logview.go #657

wants to merge 3 commits into from

Conversation

xlplbo
Copy link

@xlplbo xlplbo commented Nov 27, 2019

fixed logview example

@xlplbo
Update logview.go
b0816ea 
fixed logview example
@xlplbo xlplbo mentioned this pull request Nov 27, 2019
Open
@xlplbo
LoadIconWithScaleDown failed
70d902f 
when LoadIconWithScaleDown failed, try to call LoadImage again
rozmansi referenced this pull request Nov 27, 2019
@rozmansi
Icon: Switch to LoadIconWithScaleDown()
c0bb82a 
Legacy LoadImage() picks a smaller icon variant and scales it up when
the desired size is not available. LoadIconWithScaleDown() introduced in
Windows Vista picks a larger icon variant and scales it down producing
slightly better results.

Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi
rozmansi approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@rozmansi rozmansi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

70d902f looks good to me. I'd suggest you make separate PR for separate issues next time.

@xlplbo
Copy link
Author

xlplbo commented Dec 6, 2019

70d902f looks good to me. I'd suggest you make separate PR for separate issues next time.

ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozmansi rozmansi rozmansi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xlplbo @rozmansi