Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add installation method on Fedora using snaps #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robvdl
Copy link
Member

@robvdl robvdl commented Mar 29, 2018

Thanks @johncurley for adding this and testing

@robvdl robvdl requested a review from johncurley March 29, 2018 02:07
@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          45       45           
  Lines        1293     1293           
=======================================
  Hits         1186     1186           
  Misses        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a3ebc...75ef3d3. Read the comment docs.

@robvdl
Copy link
Member Author

robvdl commented Mar 29, 2018

Several things need to be added:

  • The Fedora SNAP method seems to work fine with SELinux and doesn't encourage the user to disable it, so it might actually be best to recommend the SNAP method first even on Fedora, rather than last.
  • The Fedora COPR method is missing the lxd-client dependency

@johncurley mentioned he might be able to send a patch to the COPR repository maintainer to sort the missing SELinux rules out. But it does seem that the SNAP package is better maintained than the COPR method so we really should be mentioning it first instead of last.

@robvdl
Copy link
Member Author

robvdl commented Mar 29, 2018

So it turns out the COPR method isn't even working anymore? Something about a missing dependency, we should really be listing the SNAP way first then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants