Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix broken links #6207

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

becseya
Copy link
Contributor

@becseya becseya commented May 9, 2024

Fixing broken links of:

Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I tested the docs link and it works!

docs/integration/bindings/micropython.rst Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@kisvegabor
Copy link
Member

Thanks! (I thought there will be more broken links 😅 )

@becseya
Copy link
Contributor Author

becseya commented May 9, 2024

@kisvegabor there might be, that's why I opened #6208

Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks like the link text matches the header name closest to the ref. If you wanted "CODING STYLE" back, you could do :ref:`CODING STYLE <coding-style>` like here.

Looks good the way it is though:

image

@becseya
Copy link
Contributor Author

becseya commented May 10, 2024

I actually prefer matching the title over all caps.

On the other hand, the dot at the end of the sentence was removed accidentally, so I've pushed again.

@becseya becseya requested a review from kisvegabor May 10, 2024 20:36
@FASTSHIFT FASTSHIFT changed the title fix(docs): Broken links fix(docs): fix broken links May 12, 2024
@kisvegabor kisvegabor merged commit bb9ff17 into lvgl:master May 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants