fix(imagebutton): tiling regression #6195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
A regression was introduced by #6029. The
lv_imagebutton
does not set theimage_area
field of thelv_draw_image_dsc_t
so it still holds the default value set bylv_draw_image_dsc_init
of{0, 0, LV_COORD_MIN, 0}
when it reaches_lv_draw_image_tiled_helper
.If
draw_dsc->image_area
is the invalid, fallback oncoords
which is what it used to always use before #6029. What I do not know is whether this fix will undo the fix done by #6029. @kisvegabor are you able to determine this? Thanks.Added a test so imagebutton does not break again.
At the time of creating this PR:
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.