fix(arc): arc pressing bounds detection #6188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Fixes #5870
1
Fix an issue where the start and end angle of the arc are not processed correctly if the start angle is smaller than the end angle (and the end angle was <=360 when it was set with the setter).
This is the whole fix
It works because the
angle
parameter in that function is relative toarc->bg_angle_start
. Theelse
branch already did the correct thing. I think theelse
was casually fixed by 84c8cf82
I simplified the rest of the function given that
smaller_angle
is always 0 and all the parameters are non-negative.@C47D if you can catch anything I oversimplified please comment.
3
I fixed the "big jump prevention logic" which seemed to be misbehaving in master.
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.