Fix TLSF returning the wrong pointer when the requested size is too large

[embeddedt]

Description of the feature or fix

• Limit test runs to 15 seconds so tests don't hang forever and instead fail.
• Make sure an LV_ASSERT_MSG causes the test to fail instead of entering a while(1); loop.
• Add a test for UsageFault Excepetion received when trying to allocate a buffer bigger than LV_MEM_SIZE #3324. Unfortunately it seems to pass at the moment.

Checkpoints

• Follow the styling guide
• Run code-format.py from the scripts folder. astyle needs to be installed.
• Update the documentation

[embeddedt]

I have realized that the assert statements are an issue in general, because I actually want the test to pass if an assertion happens, and fail otherwise (the opposite of the default logic). The cleanest solution would be if the testing framework had a feature built-in to invert the pass/fail logic, but Unity does not appear to have that. I'll need to think of an alternate solution if we want a CI test for #3324.

[kisvegabor]

I believe the same should be tested with lv_mem_alloc/free/realloc where we can see the returned value and decide to fail or pass.

  void * buf = lv_mem_alloc(20);
  printf("%p\n", buf);
  buf = lv_mem_realloc(buf, LV_MEM_SIZE + 16384);
  printf("%p\n", buf);

Results in

0x56222ce78510
0x56222ce78510

Anyway we can fix this issue by updating lv_tlsf.c. That's we have a copy of these files and not submodules.

[embeddedt]

I found the issue. adjust_request_size in TLSF returns 0 if the provided size is larger than the maximum block size, and that causes lv_tlsf_realloc to think the allocation doesn't need resizing just below here.

What do you think of my fix?

EDIT: It seems that the issue was mentioned upstream but never addressed. mattconte/tlsf#22

[kisvegabor]

LGTM!

It seems that the issue was mentioned upstream but never addressed. mattconte/tlsf#22

I wanted to suggest reporting it in the upstream.