Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop >= LFS_ZERO (always true, generates warning) #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop >= LFS_ZERO (always true, generates warning) #135

wants to merge 1 commit into from

Commits on Aug 20, 2020

  1. Drop >= LFS_ZERO (always true, generates warning) 

    On the line that says:

     if(strategy >= LFS_ZERO && strategy <= LFS_FOUR) {

If compiler warnings are turned up, they will give:

    lodepng.cpp: In function ‘filter’:
    lodepng.cpp:5437:3: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]

It's not a terribly useful warning here.  But it is in some cases informative and can catch misunderstandings, so nice to not have to disable it in a build that treats warnings as errors.
    @AE1020
    AE1020 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    e2a3c01 View commit details
    Browse the repository at this point in the history