Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Optimize contains_call() by adding memoization #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: Optimize contains_call() by adding memoization #105

wants to merge 1 commit into from

Conversation

tomlau10
Copy link

@tomlau10 tomlau10 commented Jan 30, 2024 •
edited

This will fix #104 by adding memoization to the function contains_call(). With this optimization, the time required for linting the provided test file using both the latest version and v0.25 of luacheck is nearly identical.

@tomlau10
Copy link
Author

tomlau10 commented Feb 19, 2024 •
edited

Hi, could @alerque take a look at this when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance degradation when linting large Lua files with luacheck v0.26+
1 participant
@tomlau10