Improve names hierarchy #293
Conversation
There was a problem hiding this comment.
Thanks for taking the time to contribute.
I'll be honest this kind of makes sense to me, but I don't really understand why you moved some of the cheese and I don't have a use case where I'm confident of seeing the different you were going for. Can you suggest a project where their LDoc generated files are up to date that I can compare and see what difference this makes so I can evaluate it better?
| @@ -30,7 +30,7 @@ utils.unpack = utils.unpack or unpack or table.unpack | |||
| local append = table.insert | |||
| local lapp = require 'pl.lapp' | |||
|
|
|||
| local version = '1.4.6' | |||
| local version = '1.4.7' | |||
There was a problem hiding this comment.
Please don't bump the version number as part of PR's, well do that right before an actual release.
|
If I moved the cheese, it's probably because it didn't worked as I expected it before. I think that there is special cases where I need the If I remember well, I used it for the documentation of my thesis project: https://brenona.gricad-pages.univ-grenoble-alpes.fr/arcades/ I think I used it for the navigation bar: https://gricad-gitlab.univ-grenoble-alpes.fr/brenona/arcades/-/blob/master/assets/ldoc/ldoc.ltp#L33 It makes some times since I worked on this. If you want me to test some things, be precise please. |
To follow PR #253, this improves handling of names hierarchy:
By the way, it updates the version number. If accepted, I will update documentation accordingly.