Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic dolly speed/rotation sensitivity #251

Closed
wants to merge 10 commits into from
Closed

Conversation

keywizzle
Copy link
Contributor

-Removed excess rotation after mouse is idle for >100ms

keywizzle and others added 3 commits September 21, 2022 22:35
-Removed excess rotation after mouse is idle for >100ms
-Removed excess rotation after mouse is idle for >100ms
…erations, and rename variables to reduce ambiguity and have matching pattern in naming
@trusktr
Copy link
Member

trusktr commented Oct 23, 2022

@keywizzle a couple things we need for this PR:

  • better description, describe what this does
  • unit test to make sure we catch a regression in the math, namely because the math is a hard piece of code to understand (namely the one involving the perspective, which could break if someone updates how Scene.ts works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants