Updated dependencies to latest #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @lewis-green ! The upgrade of .net standard from 2.0 to 2.1 is not something I can accept though. .net standard 2.0 is chosen specifically because it has the widest compatibility with additional platforms. Check this page for more information. .NET Standard 2.1 is not compatible with full framework .NET at all, for example, which is a non-starter for this library as it would be commonly used in desktop POS systems which are often very slow or impossible to upgrade .NET versions (eg. they may be running on Windows 7 Embedded clients that are prohibitively expensive to upgrade). If you can stay on .NET Standard 2.0 and still upgrade the other libraries, I'd be happy to review and merge/release a new version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all dependencies.
ESCPOS_NET to .Net Standard 2.1
Libraries to latest versions