Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding responsiveTextFieldPlaceholderColor modifier to update a ResponsiveTextField's placeholder color #18

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding responsiveTextFieldPlaceholderColor modifier to update a ResponsiveTextField's placeholder color #18

wants to merge 4 commits into from

Conversation

mergesort
Copy link
Contributor

No description provided.

@mergesort
Copy link
Contributor Author

I don't think this failure is me, I think it's flaky CI.

@lukeredpath
Copy link
Owner

LGTM - do you think you might be able to add a snapshot test?

@lukeredpath
Copy link
Owner

I need to update CI to use the correct simulator version as I think Xcode has been updated.

@mergesort
Copy link
Contributor Author

Added a test, but I've never used snapshot tests so let me know if that works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mergesort @lukeredpath