Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: npm ci needs package-lock.json #212

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Conversation

Giftia
Copy link
Contributor

@Giftia Giftia commented Jun 8, 2022

No description provided.

@yanyiwu
Copy link
Collaborator

yanyiwu commented Jun 11, 2022

这个感觉不应该是git管理的?

@Giftia
Copy link
Contributor Author

Giftia commented Jun 16, 2022

这个感觉不应该是git管理的?

根据 npm docs,把 package-lock.json 交给git来管理应该是可行的:
npm docs: package-lock.json

`package-lock.json` is automatically generated ... `This file is intended to be committed into source repositories` 

@baiduren
Copy link

package-lock.json 在官方的工程里都是由git管理的,没问题的

例如: https://github.com/nodejs/nodejs.org

@yanyiwu yanyiwu merged commit 628ce6c into luckykaiyi:master Jun 25, 2022
@yanyiwu
Copy link
Collaborator

yanyiwu commented Jun 25, 2022

谢谢

@Giftia
Copy link
Contributor Author

Giftia commented Jun 27, 2022

辛苦了

@yanyiwu
Copy link
Collaborator

yanyiwu commented Oct 1, 2022

merge完后需要做什么吗?看上去似乎 #205 问题还没有被解决

@Giftia
Copy link
Contributor Author

Giftia commented Oct 7, 2022

merge完后需要做什么吗?看上去似乎 #205 问题还没有被解决

国庆后我看能不能帮上忙来跑通actions

@yanyiwu
Copy link
Collaborator

yanyiwu commented Oct 7, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants