Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add ethernet-port and wired-connection icons #2120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ericfennis
Copy link
Member

Closes #1816

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Icon use case

To indicate a network connection in a router, network switch, or similar interfaces.
Can also be used as a system icon, next to the existing system icons (wifi, Bluetooth, battery and audio etc)

Alternative icon designs

See #1816

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • x ] I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Added or changed icons

icons/ethernet-port.svgicons/wired-connection.svg

Preview cohesion icons/square-mouse-pointer.svgicons/message-square-heart.svg
icons/ethernet-port.svgicons/wired-connection.svg
icons/arrow-left.svgicons/scissors.svg
Preview stroke widths icons/ethernet-port.svgicons/wired-connection.svg
icons/ethernet-port.svgicons/wired-connection.svg
icons/ethernet-port.svgicons/wired-connection.svg
DPI Preview (24px) icons/ethernet-port.svg icons/wired-connection.svg
Icon X-rays icons/ethernet-port.svg icons/wired-connection.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const EthernetPortIcon = createLucideIcon('EthernetPort', [
  ["path",{"d":"M20.2 4H3.8C2.8 4 2 4.7 2 5.6v9.8c0 .9.8 1.6 1.8 1.6H6l3 3h6l3-3h2.2c1 0 1.8-.7 1.8-1.6V5.6c0-.9-.8-1.6-1.8-1.6"}],
  ["path",{"d":"M6 8v1"}],
  ["path",{"d":"M10 8v1"}],
  ["path",{"d":"M14 8v1"}],
  ["path",{"d":"M18 8v1"}]
])

const WiredConnectionIcon = createLucideIcon('WiredConnection', [
  ["path",{"d":"m18 8 4 4-4 4"}],
  ["path",{"d":"m6 8-4 4 4 4"}],
  ["path",{"d":"M8 12h.01"}],
  ["path",{"d":"M12 12h.01"}],
  ["path",{"d":"M16 12h.01"}]
])

stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M20.2 4H3.8C2.8 4 2 4.7 2 5.6v9.8c0 .9.8 1.6 1.8 1.6H6l3 3h6l3-3h2.2c1 0 1.8-.7 1.8-1.6V5.6c0-.9-.8-1.6-1.8-1.6" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<path d="M20.2 4H3.8C2.8 4 2 4.7 2 5.6v9.8c0 .9.8 1.6 1.8 1.6H6l3 3h6l3-3h2.2c1 0 1.8-.7 1.8-1.6V5.6c0-.9-.8-1.6-1.8-1.6" />
<path d="m15 20 3-3h2a2 2 0 0 0 2-2V6a2 2 0 0 0-2-2H4a2 2 0 0 0-2 2v9a2 2 0 0 0 2 2h2l3 3z" />

@jguddas
Copy link
Member

jguddas commented May 3, 2024

What about arcifying the eathernet-port icon?

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

wired-connection feels an oddly specific name for an abstract symbol that to my best knowledge is not a standard representation of said concept, so maybe arrow-double(-headed)-horizontal-dashed or something similar would be better?

@ericfennis
Copy link
Member Author

@karsa-mistmere Kinda true. It's more common than you might think.
image
image

Wiki: https://en.wikipedia.org/wiki/Ethernet
So not sure if we should choose a generic name since it is possibly recognized as a symbol for ethernet.
But I get you, I still have some doubts about the name. 🤔

@jguddas
Copy link
Member

jguddas commented May 3, 2024

@karsa-mistmere Kinda true. It's more common than you might think. image image

Wiki: https://en.wikipedia.org/wiki/Ethernet So not sure if we should choose a generic name since it is possibly recognized as a symbol for ethernet. But I get you, I still have some doubts about the name. 🤔

Still feel like it is describing the use case rather than what is actually depicting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethernet or Ethernet port icon
3 participants