Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added panda icon #2094

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chessurisme
Copy link
Contributor

@chessurisme chessurisme commented Apr 20, 2024

#1880

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This PR contains panda icon. Closing the issue #1880

Icon use case

  • for a kid-targeted project, and pandas are a really common choice for such icons/animals.
  • indicator for maps that there is a zoo here

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: The nose is from cat
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Apr 20, 2024
Copy link

github-actions bot commented Apr 20, 2024

Added or changed icons

icons/panda.svg

Preview cohesion icons/square-chevron-down.svg
icons/panda.svg
icons/grip-vertical.svg
Preview stroke widths icons/panda.svg
icons/panda.svg
icons/panda.svg
DPI Preview (24px) icons/panda.svg
Icon X-rays icons/panda.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PandaIcon = createLucideIcon('Panda', [
  ["path",{"d":"M11.25 17.25h1.5L12 18z"}],
  ["path",{"d":"m15 12 2 2"}],
  ["path",{"d":"M18 6.5a.5.5 0 0 0-.5-.5"}],
  ["path",{"d":"M20.69 9.67a4.5 4.5 0 1 0-7.04-5.5 8.35 8.35 0 0 0-3.3 0 4.5 4.5 0 1 0-7.04 5.5C2.49 11.2 2 12.88 2 14.5 2 19.47 6.48 22 12 22s10-2.53 10-7.5c0-1.62-.48-3.3-1.3-4.83"}],
  ["path",{"d":"M6 6.5a.495.495 0 0 1 .5-.5"}],
  ["path",{"d":"m9 12-2 2"}]
])

@jguddas
Copy link
Member

jguddas commented Apr 20, 2024

Nose does not have a 2px gap.

@chessurisme
Copy link
Contributor Author

chessurisme commented Apr 20, 2024

Nose does not have a 2px gap.

@jguddas Then the cat and dog haven't too. I inspired the nose from them.

@karsa-mistmere
Copy link
Member

I kind of feel like it's a bit too small. It is in line with cat and dog, but maybe it should be larger. 🤔
image

icons
Open lucide studio

@chessurisme
Copy link
Contributor Author

Oh yes, it is tad small. We could update it according to the changes.

Added "karsa-mistmere" because he redesign the `panda`
fix(icons/panda): fix overeager optimisation by Lucide Studio
@chessurisme
Copy link
Contributor Author

Thanks for optimizing, @karsa-mistmere .

@jguddas
Copy link
Member

jguddas commented Apr 30, 2024

  • The dots inside the ears make it look a bit like a frog at 100%.
  • The eyes could also be consistent with the other animal icons.
  • The name could be bear or even bear-sad.

icons
Open lucide studio

@chessurisme
Copy link
Contributor Author

chessurisme commented Apr 30, 2024

What if we can add those lines through the head like those initial design instead of ear holes?
That looks like a panda for me—idk if it looks smaller just like the initial design, but let us try visually.

Panda's eyes are tricky, tbh. 🙂‍↕️

IMHO, the bear is good enough for another icon.

Could a panda be possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants